frankgh commented on code in PR #134:
URL:
https://github.com/apache/cassandra-analytics/pull/134#discussion_r2246398393
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraJobInfo.java:
##########
@@ -19,24 +19,29 @@
package org.apache.cassandra.spark.bulkwriter;
+import java.util.NoSuchElementException;
import java.util.UUID;
import
org.apache.cassandra.spark.bulkwriter.cloudstorage.coordinated.CoordinatedWriteConf;
+import
org.apache.cassandra.spark.bulkwriter.cloudstorage.coordinated.MultiClusterContainer;
import org.apache.cassandra.spark.bulkwriter.token.ConsistencyLevel;
import org.apache.cassandra.spark.data.QualifiedTableName;
+import org.apache.cassandra.spark.utils.Preconditions;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
public class CassandraJobInfo implements JobInfo
{
private static final long serialVersionUID = 6140098484732683759L;
protected final BulkSparkConf conf;
- protected final UUID restoreJobId;
+ // restoreJobId per cluster; it is guranteed to be non-empty
Review Comment:
```suggestion
// restoreJobId per cluster; it is guaranteed to be non-empty
```
##########
cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/bulkwriter/cloudstorage/coordinated/MultiClusterContainerTest.java:
##########
@@ -189,6 +193,45 @@ void testForEach()
});
}
+ @Test
+ void testSerializationAndDeserializationWithSingleClusterContainer()
throws IOException, ClassNotFoundException
+ {
+ UUID expectedJobId = UUID.randomUUID();
+ MultiClusterContainer<UUID> container =
MultiClusterContainer.ofSingle(expectedJobId);
+
+ byte[] serailized = SerializationUtils.serialize(container);
Review Comment:
```suggestion
byte[] serialized = SerializationUtils.serialize(container);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
