[
https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147725#comment-13147725
]
Sylvain Lebresne commented on CASSANDRA-1740:
---------------------------------------------
Let me reformulate: I *strongly* think that we shouldn't use an uncaught
exception (or rather only caught by our default uncaught exception handler) for
this. If we have a nodetool command to stop something, then stopping it is not
an error, and thus we shouldn't have a line in the log that start with ERROR.
Not only because it scares people, but also because you don't want to have
false alert for any system that is grepping the log for ERROR. And also because
that would be super ugly.
We do want a log message at INFO though. And it wouldn't hurt to make it as
informative as we can. Something like "Stopping compaction of [sstable1,
sstabl2, ...] as requested by user". Now I care less whether we use an
exception internally to achieve this or not, and I could see benefits in
throwing an exception for the JMX commands that are stopped, but I'm -1 on
having an ERROR log message for a user triggered action.
As for stopping validation compaction, this will actually leave repair
compaction hanging. It's probably ok to add it still since it's better than
nothing, but this ticket should probably spawn a specific 'stop repair' ticket.
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.0.3
>
> Attachments: 0001-Patch-to-Stop-compactions.patch,
> CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to
> stop and restart the entire Cassandra server. Please provide nodetool
> commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
