[ https://issues.apache.org/jira/browse/CASSANDRA-20827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018752#comment-18018752 ]
Stefan Miklosovic commented on CASSANDRA-20827: ----------------------------------------------- CASSANDRA-20856 added redacting of credentials / sensitive values. Your patch does not reflect this. What it does is that if it detects Map it will just return JSON without actually redacting anything. That is what I meant by "there were changes done related to this code after CASSANDRA-20856" I wrote earlier. > Represent complex settings as JSON on system_views.settings table > ----------------------------------------------------------------- > > Key: CASSANDRA-20827 > URL: https://issues.apache.org/jira/browse/CASSANDRA-20827 > Project: Apache Cassandra > Issue Type: Improvement > Components: Local/Config > Reporter: Paulo Motta > Assignee: Marko Tsymbaliuk > Priority: Normal > Time Spent: 40m > Remaining Estimate: 0h > > Complex configuration (maps/sets/lists) are represented as > Collections.toString() on {{system.settings}} virtual table: > {code:java} > cqlsh> select * from system_views.settings where name='seed_provider' ; > name | value > ------+------- > (0 rows) > cqlsh> select * from system_views.settings where > name='seed_provider.parameters' ; > name | value > --------------------------+------------------------ > seed_provider.parameters | {seeds=127.0.0.1:7000} > {code} > While this is fine for human consumption, it's not ideal for programmatic > access, since it requires custom parsing. > This ticket is to add ability of representing complex types as JSON on > {{system.settings}} and potentially making it default in trunk, so the above > would return: > {code:java} > cqlsh> select * from system_views.settings where name='seed_provider' ; > name | value > ------+------- > (0 rows) > cqlsh> select * from system_views.settings where > name='seed_provider.parameters' ; > name | value > --------------------------+------------------------ > seed_provider.parameters | {"seeds": "127.0.0.1:7000"}{code} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org