frankgh commented on code in PR #145:
URL:
https://github.com/apache/cassandra-analytics/pull/145#discussion_r2430747189
##########
analytics-sidecar-client/src/main/java/org/apache/cassandra/sidecar/client/retry/IgnoreConflictRetryPolicy.java:
##########
@@ -32,7 +32,7 @@
public class IgnoreConflictRetryPolicy extends ExponentialBackoffRetryPolicy
{
@VisibleForTesting
- IgnoreConflictRetryPolicy()
+ public IgnoreConflictRetryPolicy()
Review Comment:
is this change needed?
##########
analytics-sidecar-client/src/main/java/org/apache/cassandra/sidecar/client/retry/ExponentialBackoffRetryPolicy.java:
##########
@@ -79,7 +79,7 @@ public ExponentialBackoffRetryPolicy(int maxRetries, long
retryDelayMillis, long
* @return the number of milliseconds to wait before attempting the next
request
*/
@Override
- protected long retryDelayMillis(int attempts)
+ public long retryDelayMillis(int attempts)
Review Comment:
any reason we need this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
