yifan-c commented on code in PR #59:
URL:
https://github.com/apache/cassandra-easy-stress/pull/59#discussion_r2511429836
##########
.github/workflows/ci.yml:
##########
@@ -0,0 +1,126 @@
+name: CI
+
+on:
+ push:
+ branches:
+ - main
+ pull_request:
+ branches:
+ - main
+
+jobs:
+ test:
+ runs-on: ubuntu-latest
+ timeout-minutes: 30
+
+ strategy:
+ matrix:
+ java: [17, 21]
+ test-task: ["test40", "test41", "test50"]
+ fail-fast: false
+
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v4
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v4
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: "temurin"
+
+ - name: Setup Gradle
+ uses: gradle/actions/setup-gradle@v3
+
+ - name: Run tests (${{ matrix.test-task }})
+ run: ./gradlew ${{ matrix.test-task }}
+
+ lint:
+ runs-on: ubuntu-latest
+ timeout-minutes: 10
+
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v4
+
+ - name: Set up JDK 17
+ uses: actions/setup-java@v4
+ with:
+ java-version: 17
+ distribution: "temurin"
+
+ - name: Setup Gradle
+ uses: gradle/actions/setup-gradle@v3
+
+ - name: Run ktlint
+ run: ./gradlew ktlintCheck
+
+ detekt:
+ runs-on: ubuntu-latest
+ timeout-minutes: 10
+
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v4
+
+ - name: Set up JDK 17
+ uses: actions/setup-java@v4
+ with:
+ java-version: 17
+ distribution: "temurin"
+
+ - name: Setup Gradle
+ uses: gradle/actions/setup-gradle@v3
+
+ - name: Run detekt
+ run: ./gradlew detekt
+
+ kover:
+ runs-on: ubuntu-latest
+ timeout-minutes: 10
+
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v4
+
+ - name: Set up JDK 17
+ uses: actions/setup-java@v4
+ with:
+ java-version: 17
+ distribution: "temurin"
+
+ - name: Setup Gradle
+ uses: gradle/actions/setup-gradle@v3
+
+ - name: Run tests and generate coverage
+ run: ./gradlew test koverXmlReport -x test40 -x test41 -x test50
+
+ build:
+ runs-on: ubuntu-latest
+ timeout-minutes: 15
+ needs: [test, lint, detekt, kover]
+ if: github.ref == 'refs/heads/main'
Review Comment:
I meant the `build` job is skipped for PRs. But there could be bugs that
break building the artifacts, and it won't be caught until it is merged.
I think we can still run the build job, but skip uploading. (i.e. moving the
condition to the `Upload build artifact` step).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
