absurdfarce commented on code in PR #1260:
URL:
https://github.com/apache/cassandra-python-driver/pull/1260#discussion_r2600342283
##########
cassandra/concurrent.py:
##########
@@ -81,7 +81,7 @@ def _execute_next(self):
def _execute(self, idx, statement, params):
self._exec_depth += 1
try:
- future = self.session.execute_async(statement, params,
timeout=None, execution_profile=self._execution_profile)
+ future = self.session.execute_async(statement, params,
execution_profile=self._execution_profile)
Review Comment:
Agree with the analysis here. execute_async() has a [default
value](https://github.com/apache/cassandra-python-driver/blob/3.29.3/cassandra/cluster.py#L2679-L2681)
for the timeout param which results in the default timeout being used as long
as no override is supplied
([here](https://github.com/apache/cassandra-python-driver/blob/3.29.3/cassandra/cluster.py#L3021-L3022)
by way of [this
call](https://github.com/apache/cassandra-python-driver/blob/3.29.3/cassandra/cluster.py#L2720-L2722)).
Code path in _create_response_future() is slightly different when execution
contexts are in play but the same analysis seems to hold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
