[ 
https://issues.apache.org/jira/browse/CASSANDRA-20081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18046984#comment-18046984
 ] 

Arvind Kandpal commented on CASSANDRA-20081:
--------------------------------------------

I have submitted a Pull Request to address this issue.

PR: [#4540|https://github.com/apache/cassandra/pull/4540]

Summary of changes:
1. Addressed point (b): Modified `CompactionTask` to persist the compaction 
strategy (e.g., STCS, LCS) and compaction type (e.g., Major, Minor) into a new 
column `compaction_type` and the existing `compaction_properties` column in 
`system.compaction_history`.
2. Addressed point (c): Updated `nodetool compactionhistory` to display bytes 
in a human-readable format (KiB, MiB) by default. Added a  '-n' / 
'--no-human-readable' flag to support raw byte output.

All relevant unit tests (SystemKeyspaceTest, CompactionTaskTest, 
CompactionHistoryTest) have been updated and are passing.

Looking forward to the review.

> Enhance nodetool compactionhistory to report compaction type and strategy
> -------------------------------------------------------------------------
>
>                 Key: CASSANDRA-20081
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20081
>             Project: Apache Cassandra
>          Issue Type: New Feature
>          Components: Tool/nodetool
>            Reporter: Brad Schoening
>            Assignee: Arvind Kandpal
>            Priority: Normal
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> It would be useful for compactionhistory to have:
> a) updated documentation for nodetool [compactionhistory 
> |https://cassandra.apache.org/doc/stable/cassandra/tools/nodetool/compactionhistory.html]
>  describing the columns *rows_merged* and {*}compaction_properties{*}. This 
> StackOverflow article provides a good descriptions of rows_merged:  [What 
> does rows_merged mean in 
> compactionhistory|https://stackoverflow.com/questions/27566558/what-does-rows-merged-mean-in-compactionhistory]
> b) the compaction strategy used: STCS, LCS, TWCS, UCS and sub-properties. For 
> example, with level, the from-level and to-level could be reported.
> c) also useful would be to make the bytes in and out human readable by 
> default, since there is already an -f option for machine readable output.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to