[
https://issues.apache.org/jira/browse/CASSANDRA-21072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18054694#comment-18054694
]
Brandon Williams commented on CASSANDRA-21072:
----------------------------------------------
Hi Arnav,
You raise an interesting point! Looking into this more, I see that
MessageParams are set for LocalReadSizeTooLargeException and
QueryReferencingTooManyIndexesException so
[WarningContext|https://github.com/apache/cassandra/blame/cassandra-5.0/src/java/org/apache/cassandra/service/reads/thresholds/WarningContext.java#L59]
should handle them. A cleaner fix for TombstoneOverwhelmingException could be
also setting TOMBSTONE_FAIL in MessageParams before throwing, similar to
LocalReadSizeTooLargeException.
> Also can I assign this task to myself
Yes! But I see that has been kindly done already by Maxwell.
> TombstoneOverwhelmingException gets swallowed when tracking warnings
> --------------------------------------------------------------------
>
> Key: CASSANDRA-21072
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21072
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Feature/Guardrails
> Reporter: Brandon Williams
> Assignee: Arnav Chakraborty
> Priority: Normal
> Fix For: 5.0.x, 6.x
>
>
> ReadCommandVerbHandler is catching RejectException and returning an empty
> response instead of propagating the failure when warnings tracking is
> enabled, see
> https://github.com/datastax/cassandra/commit/f1223ec9fd9c724f00acbe338e053f3533617c8a
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
