[
https://issues.apache.org/jira/browse/CASSANDRA-21145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18055128#comment-18055128
]
Arvind Kandpal edited comment on CASSANDRA-21145 at 1/29/26 11:25 AM:
----------------------------------------------------------------------
Hi , I have linked the PR to fix the test regression. Please review.
was (Author: JIRAUSER311141):
Hi , I have linked the PR to fix the test regression. Please review.
*PR:* [https://github.com/apache/cassandra/pull/4594]
> Fix CI regression in CompactionHistoryTest introduced by CASSANDRA-20081
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-21145
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21145
> Project: Apache Cassandra
> Issue Type: Bug
> Components: CI, Tool/nodetool
> Reporter: Arvind Kandpal
> Assignee: Arvind Kandpal
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The changes introduced in
> [CASSANDRA-20081|https://issues.apache.org/jira/browse/CASSANDRA-20081] added
> validation for compaction properties in `*nodetool compactionhistory*` output.
> However, this caused a regression in `CompactionHistoryTest` on CI
> environments. The test expects the output to show
> `SizeTieredCompactionStrategy` (STCS), but in the CI environment (trunk), the
> default strategy is often randomized or set to `UnifiedCompactionStrategy`
> (UCS).
> CI Failure Link:
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/2387/#showFailuresLink]
> Tests / test-latest jdk11 3/20 /
> org.apache.cassandra.tools.nodetool.CompactionHistoryTest.testCompactionProperties[0:
> cmd=[compact] compactionType=Major compaction
> systemTableRecord=1]-latest_jdk11_x86_64
> Tests / test-latest jdk17 3/20 /
> org.apache.cassandra.tools.nodetool.CompactionHistoryTest.testCompactionProperties[0:
> cmd=[compact] compactionType=Major compaction
> systemTableRecord=1]-latest_jdk17_x86_64
> Tests / test-latest jdk11 3/20 /
> org.apache.cassandra.tools.nodetool.CompactionHistoryTest.testCompactionProperties[1:
> cmd=[garbagecollect] compactionType=Remove deleted data
> systemTableRecord=10]-latest_jdk11_x86_64
> Tests / test-latest jdk17 3/20 /
> org.apache.cassandra.tools.nodetool.CompactionHistoryTest.testCompactionProperties[1:
> cmd=[garbagecollect] compactionType=Remove deleted data
> systemTableRecord=10]-latest_jdk17_x86_64
> Tests / test-latest jdk11 3/20 /
> org.apache.cassandra.tools.nodetool.CompactionHistoryTest.testCompactionProperties[2:
> cmd=[upgradesstables, -a] compactionType=Upgrade sstables
> systemTableRecord=10]-latest_jdk11_x86_64
> Tests / test-latest jdk17 3/20 /
> org.apache.cassandra.tools.nodetool.CompactionHistoryTest.testCompactionProperties[2:
> cmd=[upgradesstables, -a] compactionType=Upgrade sstables
> systemTableRecord=10]-latest_jdk17_x86_64
> Error Log:
> Output did not contain expected data.
> Expected Props: \{strategy=SizeTieredCompactionStrategy, ...}
> Actual Output: \{strategy=UnifiedCompactionStrategy, ...}
> The fix is to explicitly enforce `SizeTieredCompactionStrategy` in the test's
> `CREATE TABLE` statement to ensure deterministic output regardless of the
> test environment defaults.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
