[
https://issues.apache.org/jira/browse/CASSANDRA-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18061860#comment-18061860
]
Maxim Muzafarov commented on CASSANDRA-20178:
---------------------------------------------
The same problem with the locale is in the CompactionStats cli command with
CompactionStatsTest:
[https://github.com/apache/cassandra/blob/cassandra-5.0.6/src/java/org/apache/cassandra/tools/nodetool/CompactionStats.java#L107]
and Ring command:
[https://github.com/apache/cassandra/blob/cassandra-5.0.6/src/java/org/apache/cassandra/tools/nodetool/Ring.java#L179C76-L179C89]
having a wrapper the same as in LocalizeString is a good idea.
> SetGetCompactionThroughputTest fails, should be locale agnosting
> ----------------------------------------------------------------
>
> Key: CASSANDRA-20178
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20178
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Maxim Muzafarov
> Assignee: lanqing yang
> Priority: Normal
> Labels: lhf
> Fix For: 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The problem is related to CASSANDRA-13890 where it was introduced. The test
> {{org.apache.cassandra.tools.nodetool.SetGetCompactionThroughputTest#testCurrentCompactionThroughput}}
> fails because the output representation we are verifying depends on the
> locale. For instance, the en_US locale uses a period ( . ), whereas the de_DE
> locale uses a comma ( , ).
> Which means the test is not locale-agnostic. The regex pattern must be fixed.
> {code}
> FAILS:
> Current compaction throughput (1 minute): 0,000 MiB/s
> Current compaction throughput (5 minute): 0,000 MiB/s
> Current compaction throughput (15 minute): 0,000 MiB/s
> SUCCEED:
> Current compaction throughput (1 minute): 0.000 MiB/s
> Current compaction throughput (5 minute): 0.000 MiB/s
> Current compaction throughput (15 minute): 0.000 MiB/s
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
