[ 
https://issues.apache.org/jira/browse/CASSANDRA-21176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18062121#comment-18062121
 ] 

Stefan Miklosovic commented on CASSANDRA-21176:
-----------------------------------------------

I do not think this patch works (1)

https://github.com/apache/cassandra/commit/1461e754e8969fc56c14206bcfafb6d91bdb5fef

I have noticed that it started to fail CI quite badly. Look at (1) for example. 
There is direct correlation between time we merged this and when it started to 
fail like that.  This is the last one which was OK (2). Then 560 and 561 
started to fail consistently on that. It is same all over again like this

{code}
junit.framework.AssertionFailedError: Error in test '4.0.20 -> [5.0.7]' while 
upgrading to '5.0.7'; successful upgrades []
        at 
org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:362)
        at 
org.apache.cassandra.distributed.upgrade.MixedModePaxosTestBase.ttldPaxosStateTest(MixedModePaxosTestBase.java:119)
        at 
org.apache.cassandra.distributed.upgrade.MixedModePaxosTestBase.legacyAwareTTldPaxosStateTest(MixedModePaxosTestBase.java:131)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Caused by: java.lang.RuntimeException: java.lang.ClassNotFoundException: 
org.apache.cassandra.distributed.impl.IsolatedExecutor
        at 
org.apache.cassandra.distributed.impl.IsolatedExecutor.lookupDeserializeOneObject(IsolatedExecutor.java:239)
        at 
org.apache.cassandra.distributed.impl.IsolatedExecutor.transferAdhocPropagate(IsolatedExecutor.java:204)
        at 
org.apache.cassandra.distributed.impl.AbstractCluster$Wrapper.newInstance(AbstractCluster.java:311)
        at 
org.apache.cassandra.distributed.impl.AbstractCluster$Wrapper.delegateForStartup(AbstractCluster.java:286)
        at 
org.apache.cassandra.distributed.impl.AbstractCluster$Wrapper.startup(AbstractCluster.java:404)
        at 
org.apache.cassandra.distributed.impl.AbstractCluster$Wrapper.startup(AbstractCluster.java:377)
        at 
org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:352)
Caused by: java.lang.ClassNotFoundException: 
org.apache.cassandra.distributed.impl.IsolatedExecutor
        at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:476)
        at 
org.apache.cassandra.distributed.shared.InstanceClassLoader.findClass(InstanceClassLoader.java:164)
        at 
org.apache.cassandra.distributed.shared.InstanceClassLoader.loadClassInternal(InstanceClassLoader.java:147)
        at 
org.apache.cassandra.distributed.shared.InstanceClassLoader.loadClass(InstanceClassLoader.java:133)
        at 
org.apache.cassandra.distributed.impl.IsolatedExecutor.lookupDeserializeOneObject(IsolatedExecutor.java:235)
{code}

However what is interesting is that it is not happening in trunk so far. I am 
quite baffled. I am going to revert this from everywhere for now and will check 
how 5.0 behaves because this is not normal. 

(1) https://ci-cassandra.apache.org/job/Cassandra-5.0/561/#showFailuresLink
(2) https://ci-cassandra.apache.org/job/Cassandra-5.0/559/

> Update maven shade plugin version
> ---------------------------------
>
>                 Key: CASSANDRA-21176
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-21176
>             Project: Apache Cassandra
>          Issue Type: Bug
>          Components: Build
>            Reporter: Bernardo Botella Corbi
>            Assignee: Bernardo Botella Corbi
>            Priority: Normal
>             Fix For: 4.0.20, 4.1.11, 5.0.7, 5.1
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Right now, the maven shade plugin (3.4.1) breaks the dtest building script. 
> This is true for all supported branches and trunk. Updating it to 3.6.1 fixes 
> the issue.
> Similar patch was applied to Sidecar in 
> https://github.com/apache/cassandra-sidecar/commit/6cf4b4c9c818efac825af999fb47ac545f75d430



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to