This is an automated email from the ASF dual-hosted git repository.
konstantinov pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/trunk by this push:
new 345df213 Fix bootstrap dtests to start nodes sequentially for all
versions to avoid token conflicts (pre-TCM) and CMS discovery failures (TCM)
345df213 is described below
commit 345df21387fe5f2f767d9efca02ac43a5db78f47
Author: samlightfoot <[email protected]>
AuthorDate: Mon Feb 23 20:51:54 2026 +0000
Fix bootstrap dtests to start nodes sequentially for all versions to avoid
token conflicts (pre-TCM) and CMS discovery failures (TCM)
patch by Sam Lightfoot; reviewed by Dmitry Konstantinov, Sam Tunnicliffe
for CASSANDRA-21185
---
bootstrap_test.py | 38 +++++++++++++++-----------------------
1 file changed, 15 insertions(+), 23 deletions(-)
diff --git a/bootstrap_test.py b/bootstrap_test.py
index 885b3578..9613eb55 100644
--- a/bootstrap_test.py
+++ b/bootstrap_test.py
@@ -45,6 +45,17 @@ class BootstrapTester(Tester):
r'Streaming error occurred'
)
+ def _start_cluster_sequentially(self, cluster):
+ """Start all nodes one at a time, waiting for each to be ready.
+
+ Sequential startup is required for all Cassandra versions:
+ <= 5.0: simultaneous start causes token assignment conflicts
(CASSANDRA-19097)
+ >= 5.1: seed must be reachable before non-seeds begin CMS discovery
(CASSANDRA-21185)
+ """
+ for node in cluster.nodelist():
+ node.start(wait_for_binary_proto=True)
+ cluster.start()
+
def _base_bootstrap_test(self, bootstrap=None, bootstrap_from_version=None,
enable_ssl=None):
def default_bootstrap(cluster, token):
@@ -251,12 +262,7 @@ class BootstrapTester(Tester):
cluster = self.cluster
cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
'True')
cluster.populate(3)
- if cluster.version() <= '5.0':
- # Nodes need to be started one by one pre-TCM, not all at once.
See CASSANDRA-19097
- cluster.nodelist()[0].start(wait_for_binary_proto=True)
- cluster.nodelist()[1].start(wait_for_binary_proto=True)
- cluster.nodelist()[2].start(wait_for_binary_proto=True)
- cluster.start()
+ self._start_cluster_sequentially(cluster)
node1 = cluster.nodes['node1']
node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8',
'-schema', 'replication(factor=2)'])
@@ -524,11 +530,7 @@ class BootstrapTester(Tester):
cluster = self.cluster
cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
'True')
cluster.populate(2)
- if cluster.version() <= '5.0':
- # Nodes need to be started one by one pre-TCM, not all at once.
See CASSANDRA-19097
- cluster.nodelist()[0].start(wait_for_binary_proto=True)
- cluster.nodelist()[1].start(wait_for_binary_proto=True)
- cluster.start()
+ self._start_cluster_sequentially(cluster)
(node1, node2) = cluster.nodelist()
node1.stress(['write', 'n=1K', 'no-warmup', '-schema',
'replication(factor=2)',
@@ -630,12 +632,7 @@ class BootstrapTester(Tester):
cluster = self.cluster
cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
'True')
cluster.populate(3)
- if cluster.version() <= '5.0':
- # Nodes need to be started one by one pre-TCM, not all at once.
See CASSANDRA-19097
- cluster.nodelist()[0].start(wait_for_binary_proto=True)
- cluster.nodelist()[1].start(wait_for_binary_proto=True)
- cluster.nodelist()[2].start(wait_for_binary_proto=True)
- cluster.start()
+ self._start_cluster_sequentially(cluster)
stress_table = 'keyspace1.standard1'
@@ -671,12 +668,7 @@ class BootstrapTester(Tester):
cluster = self.cluster
cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
'True')
cluster.populate(3)
- if cluster.version() <= '5.0':
- # Nodes need to be started one by one pre-TCM, not all at once.
See CASSANDRA-19097
- cluster.nodelist()[0].start(wait_for_binary_proto=True)
- cluster.nodelist()[1].start(wait_for_binary_proto=True)
- cluster.nodelist()[2].start(wait_for_binary_proto=True)
- cluster.start()
+ self._start_cluster_sequentially(cluster)
stress_table = 'keyspace1.standard1'
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
