lukasz-antoniak commented on code in PR #175:
URL:
https://github.com/apache/cassandra-analytics/pull/175#discussion_r2916224812
##########
cassandra-four-zero-bridge/src/main/java/org/apache/cassandra/db/commitlog/BufferingCommitLogReader.java:
##########
@@ -320,10 +320,11 @@ private void readCommitLogSegment() throws IOException
// If the loop finished naturally (iterator exhausted) without
hitting an error or limit,
// ensure the position reflects the end of the file. If we aborted
early due to an error
// or mutation limit, 'this.position' remains at the last valid
read offset.
- if (statusTracker.shouldContinue())
- {
- this.position = (int) log.maxOffset();
- }
+ // TODO(lantoniak): Does not this change break markers in the
stored state and prevents commit log from re-read?
+// if (statusTracker.shouldContinue())
Review Comment:
The issue is being fixed in PR
https://github.com/apache/cassandra-analytics/pull/179.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
