skoppu22 commented on code in PR #183:
URL:
https://github.com/apache/cassandra-analytics/pull/183#discussion_r2959475255
##########
cassandra-four-zero-types/src/main/java/org/apache/cassandra/spark/data/complex/CqlMap.java:
##########
@@ -120,15 +120,15 @@ public void addCell(final
org.apache.cassandra.db.rows.Row.Builder rowBuilder,
ColumnMetadata cd,
long timestamp,
int ttl,
- int now,
+ long now,
Object value)
{
for (Map.Entry<?, ?> entry : ((Map<?, ?>) value).entrySet())
{
if (ttl != NO_TTL)
{
- rowBuilder.addCell(BufferCell.expiring(cd, timestamp, ttl,
now, valueType().serialize(entry.getValue()),
-
CellPath.create(keyType().serialize(entry.getKey()))));
+ rowBuilder.addCell(CqlType.expiring(cd, timestamp, ttl, now,
valueType().serialize(entry.getValue()),
+
CellPath.create(keyType().serialize(entry.getKey()))));
Review Comment:
CqlMap is implemented in C* 4.0 bridge and not extended (i.e, reused) in C*
5.0 bridge. While 4.0 bridge expects int for nowInSec, 5.0 bridge expects long
for the same. I have modified this to use CqlType's method which is implemented
separately for both bridges and uses appropriate type in corresponding bridges.
Without this change, we will have to implement CqlMap again in 5.0 bridge and
override this function to pass long value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
