skoppu22 commented on code in PR #169:
URL:
https://github.com/apache/cassandra-analytics/pull/169#discussion_r3009772322
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##########
@@ -56,9 +58,21 @@ protected CassandraBulkWriterContext(@NotNull
BulkWriterConfig config)
}
@Override
- protected ClusterInfo buildClusterInfo()
+ protected String getLowestCassandraVersion(@NotNull BulkSparkConf conf)
{
- return new CassandraClusterInfo(bulkSparkConf());
+ return CassandraClusterInfo.getLowestCassandraVersion(conf, null);
+ }
+
+ @Override
+ protected Set<String> getSSTableVersionsOnCluster(@NotNull BulkSparkConf
conf)
+ {
+ return CassandraClusterInfo.getSSTableVersionsOnCluster(conf, null);
+ }
+
+ @Override
+ protected ClusterInfo buildClusterInfo(CassandraVersion bridgeVersion)
+ {
+ return new CassandraClusterInfo(bulkSparkConf(), bridgeVersion);
Review Comment:
Fixed this. There is a chicken and egg problem here. Context is needed to
determine the bridge, and context contains determined bridge version. Hence
creating preliminary context initially (with null bridge version) which is used
for bridge determination, then we create final context with the bridge value.
Also made changes to reuse nodesettings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
