Klose6 commented on code in PR #187:
URL:
https://github.com/apache/cassandra-analytics/pull/187#discussion_r3028886301
##########
cassandra-analytics-cdc-sidecar/src/main/java/org/apache/cassandra/cdc/sidecar/SidecarCdcBuilder.java:
##########
@@ -43,6 +44,8 @@ public class SidecarCdcBuilder extends CdcBuilder
{
protected ClusterConfigProvider clusterConfigProvider;
protected SidecarCdcClient sidecarCdcClient;
+ @NotNull
+ protected Function<String, Integer> portResolver;
Review Comment:
I double check the latest commit and think we don't need the changes on
SidecarCdcBuilder now because the SidecarCdcClient is a input parameter to
SidecarCdc now, remove the withPortResolver() in SidecarCdcBuilder and only the
changes in sidecarCdcClient, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
