[
https://issues.apache.org/jira/browse/CASSSIDECAR-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18078403#comment-18078403
]
Stefan Miklosovic commented on CASSSIDECAR-449:
-----------------------------------------------
We just need to add another catch block with
{code}
catch (org.apache.kafka.common.config.ConfigException e)
{
LOGGER.error(e.getMessage());
}
{code}
into CdcPublisher.run(). As it is a periodic task, it will be retried and we
return from it when isRunning is set to true. We do not need to log whole
stacktraces, the message is just fine.
> Inserting cdc config into sidecar_internal.configs before kafka config logs
> errors
> ----------------------------------------------------------------------------------
>
> Key: CASSSIDECAR-449
> URL: https://issues.apache.org/jira/browse/CASSSIDECAR-449
> Project: Sidecar for Apache Cassandra
> Issue Type: Bug
> Reporter: Stefan Miklosovic
> Priority: Major
>
> When I do this:
> {code}
> INSERT INTO sidecar_internal.configs (service, config)
> VALUES ('cdc', {
> 'cdc_enabled': 'true',
> 'topic': 'cdc-mutations',
> 'jobid': 'docker-demo-job',
> 'datacenter': 'dc1',
> 'watermark_seconds': '259200',
> 'micro_batch_delay_millis': '1000',
> 'max_commit_logs': '4',
> 'persist_state': 'true',
> 'fail_kafka_errors': 'true',
> 'fail_kafka_too_large_errors': 'false'
> }) IF NOT EXISTS;
> -- wait some time
> INSERT INTO sidecar_internal.configs (service, config)
> VALUES ('kafka', {
> 'bootstrap.servers': 'spark-master-1:9094',
> 'key.serializer':
> 'org.apache.kafka.common.serialization.StringSerializer',
> 'value.serializer':
> 'org.apache.kafka.common.serialization.ByteArraySerializer',
> 'acks': 'all',
> 'retries': '3',
> 'linger.ms': '5',
> 'batch.size': '16384'
> }) IF NOT EXISTS;
> {code}
> It logs:
> {code}
> ERROR [sidecar-internal-worker-pool-2] 2026-05-05 13:31:50,445
> CdcPublisher.java:379 - CDC run failed
> org.apache.kafka.common.config.ConfigException: Invalid value null for
> configuration key.serializer: must be non-null.
> at
> org.apache.kafka.clients.producer.ProducerConfig.appendSerializerToConfig(ProducerConfig.java:605)
> at
> org.apache.kafka.clients.producer.KafkaProducer.<init>(KafkaProducer.java:294)
> at
> org.apache.kafka.clients.producer.KafkaProducer.<init>(KafkaProducer.java:277)
> at
> org.apache.cassandra.cdc.kafka.KafkaProducerFactory.lambda$static$0(KafkaProducerFactory.java:36)
> at
> org.apache.cassandra.cdc.kafka.KafkaPublisher.create(KafkaPublisher.java:325)
> at
> org.apache.cassandra.sidecar.cdc.CdcPublisher.eventConsumer(CdcPublisher.java:140)
> at
> org.apache.cassandra.sidecar.cdc.CdcPublisher.run(CdcPublisher.java:178)
> at
> org.apache.cassandra.sidecar.cdc.CdcPublisher.execute(CdcPublisher.java:374)
> at
> org.apache.cassandra.sidecar.tasks.PeriodicTaskExecutor.executeInternal(PeriodicTaskExecutor.java:261)
> at
> org.apache.cassandra.sidecar.tasks.PeriodicTaskExecutor.lambda$executeAndScheduleNext$3(PeriodicTaskExecutor.java:148)
> at
> io.vertx.core.impl.ContextImpl.lambda$executeBlocking$5(ContextImpl.java:205)
> at io.vertx.core.impl.ContextInternal.dispatch(ContextInternal.java:270)
> at io.vertx.core.impl.ContextImpl$1.execute(ContextImpl.java:221)
> at io.vertx.core.impl.WorkerTask.run(WorkerTask.java:56)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
> Basically, when I put cdc config in while there is not kafka config, it
> repeatedly logs errors. It stops to log them as soon as I create kafka config.
> I think this should be fixed, it might be logged without exception in a
> non-spamming manner or similar.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
