jmckenzie-dev commented on code in PR #205:
URL:
https://github.com/apache/cassandra-analytics/pull/205#discussion_r3210293557
##########
cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/BulkReaderMultiDCConsistencyTest.java:
##########
@@ -204,7 +203,7 @@ void eachQuorumIsNotQuorum() throws IOException,
NoSuchMethodException
}
catch (Exception e)
{
- if (attempt == 10 || !(e instanceof ReadTimeoutException))
+ if (attempt == 10 ||
!e.getClass().getName().endsWith("ReadTimeoutException"))
Review Comment:
ah HAH! I had a vague suspicion when I changed that on the other PR but
couldn't put my finger on it when that came back in review feedback. Hm. Would
you be willing to add a quick one-liner comment above this to explain this
mismatch so we don't break this again in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
