frankgh commented on code in PR #210:
URL:
https://github.com/apache/cassandra-analytics/pull/210#discussion_r3256230205
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RecordWriter.java:
##########
@@ -393,8 +393,8 @@ private Map<String, Object>
getBindValuesForColumns(Map<String, Object> map, Str
}
// Convert tuples to TupleValue for CQLSSTableWriter
- // - Direct tuple columns: Object[] → TupleValue
- // - Collections with tuples: List<Object[]> → List<TupleValue>
(via collection's convertForCqlWriter)
+ // - Direct tuple columns: Object[] -> TupleValue
+ // - Collections with tuples: List<Object[]> -> List<TupleValue>
(via collection's convertForCqlWriter)
Review Comment:
ditto
```suggestion
// - Collections with tuples: List<Object[]> ->
List<TupleValue> (via collection's convertForCqlWriter)
```
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RecordWriter.java:
##########
@@ -393,8 +393,8 @@ private Map<String, Object>
getBindValuesForColumns(Map<String, Object> map, Str
}
// Convert tuples to TupleValue for CQLSSTableWriter
- // - Direct tuple columns: Object[] → TupleValue
- // - Collections with tuples: List<Object[]> → List<TupleValue>
(via collection's convertForCqlWriter)
+ // - Direct tuple columns: Object[] -> TupleValue
Review Comment:
shouldn't this be `->` instead?
```suggestion
// - Direct tuple columns: Object[] -> TupleValue
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
