Copilot commented on code in PR #461:
URL:
https://github.com/apache/cassandra-nodejs-driver/pull/461#discussion_r3270368123
##########
package.json:
##########
@@ -31,7 +30,9 @@
"mocha-jenkins-reporter": "~0.4.8",
"proxyquire": "~2.1.3",
"sinon": "~15.2.0",
- "temp": ">= 0.8.3"
+ "temp": ">= 0.8.3",
+ "ts-mocha": "^10.0.0",
+ "typescript": "^5.7.3"
Review Comment:
The `test`, `unit`, `integration_short`, `integration_long`, `ci_jenkins`,
`ci_appveyor`, `ci_unit_appveyor`, and `server_api` scripts all still invoke
plain `mocha`, but the test files have been renamed to `.ts`. As a result, none
of these npm scripts will pick up tests anymore (mocha by default only loads
`.js`). Consider switching these scripts to `ts-mocha` (which was just added as
a devDependency) or adding a mocha `--extension ts` / `require
ts-node/register` configuration. The PR description suggests running `npx
ts-mocha` manually, but leaving the scripts broken will likely also break CI
invocations referencing them.
##########
package.json:
##########
@@ -18,7 +18,6 @@
"graphdb"
],
"license": "Apache-2.0",
Review Comment:
Removing the `"types": "./index.d.ts"` field is a breaking change for any
TypeScript consumer of this package. After this PR, downstream TypeScript
projects importing `cassandra-driver` will no longer get type definitions
(since `index.d.ts` is no longer shipped, and there's no replacement declared
here). Even though `tsconfig.json` enables `declaration: true` with `outDir:
"out"`, nothing in `package.json` points to the generated `.d.ts` files, and
`"main"` is not defined at all. Consider keeping `types` pointing at a valid
declaration entry point (e.g., the generated `out/index.d.ts`) and also setting
`"main"`/`"files"` so the published package still exposes types and a working
entry point during the migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
