toptobes commented on PR #462: URL: https://github.com/apache/cassandra-nodejs-driver/pull/462#issuecomment-4503688697
> Why > > > silent null checks may just cause more subtle bugs > > ? I think they can potentially fix some bugs that we didn't discover yet. But either way, I'm good. I think this PR can already fix the problem that we clearly know of. If you fix that eslint error, I will give the explicit approval. Just to step back for a second we need to decide if it's even valid to get to the end of `_refresh()` without the host or the connection being set I don't think it should be, no? Meaning if it happens, we're just enabling the bug to propagate silently instead of catching it and yelling to the user that that's happened and needs to be patched (which it really should never happen with this refresh fix or there's a bigger issue) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
