[ 
https://issues.apache.org/jira/browse/CASSSIDECAR-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18082941#comment-18082941
 ] 

Francisco Guerrero commented on CASSSIDECAR-447:
------------------------------------------------

+1

> Scope all CDC dependencies exclusively to CdcModule
> -----------------------------------------------------
>
>                 Key: CASSSIDECAR-447
>                 URL: https://issues.apache.org/jira/browse/CASSSIDECAR-447
>             Project: Sidecar for Apache Cassandra
>          Issue Type: Improvement
>          Components: CDC
>            Reporter: Yifan Cai
>            Assignee: Yifan Cai
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Many CDC classes are annotated with both @Singleton and @Inject is 
> JIT-bindable by Guice regardless of whether its owning module is installed. 
> This meant all CDC singletons could be created even when CDC was disabled, 
> simply by being injected as a transitive dependency.
> Proposing the patch to properly honor the feature flag, cdc_enabled. If the 
> feature flag is disabled, ensuring CDC objects are not instantiated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to