rustyrazorblade commented on code in PR #212:
URL:
https://github.com/apache/cassandra-analytics/pull/212#discussion_r3314561895
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/transports/storage/StorageAccessConfiguration.java:
##########
@@ -109,16 +111,22 @@ public void write(Kryo kryo, Output out,
StorageAccessConfiguration object)
{
out.writeString(object.region);
out.writeString(object.bucket);
- kryo.writeObject(out, object.storageCredentials);
+ boolean isIam = object.storageAuth instanceof IamStorageAuth;
+ out.writeBoolean(isIam);
+ if (!isIam)
Review Comment:
Agreed - definitely cheap. I did this to avoid sending parameters to the
sidecar that it doesn't know about yet. I can't recall if it would break the
endpoint now. I'm OK either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
