[ 
https://issues.apache.org/jira/browse/CASSANDRA-21326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcus Eriksson updated CASSANDRA-21326:
----------------------------------------
    Change Category: Quality Assurance
         Complexity: Normal
        Component/s: Test/dtest/python
                     Test/unit
      Fix Version/s: 7.x
             Status: Open  (was: Triage Needed)

> Fix some TCM/CMS upgrade python and in-jvm dtests when they go over upgrade 
> from 6.0 to 7.0
> -------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-21326
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-21326
>             Project: Apache Cassandra
>          Issue Type: Improvement
>          Components: Test/dtest/python, Test/unit
>            Reporter: Stefan Miklosovic
>            Assignee: Marcus Eriksson
>            Priority: Normal
>             Fix For: 7.x
>
>         Attachments: 21326-5.0.html, 21326-6.0.html, 21326-trunk.html
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> I spotted this in (1)
> Such as:
> https://pre-ci.cassandra.apache.org/job/cassandra/521/testReport/junit/org.apache.cassandra.distributed.upgrade/ClusterMetadataUpgradeAssassinateTest/Tests___jvm_dtest_upgrade_jdk11_6_6___simpleUpgradeTest__jdk11_x86_64/
> {code}
> junit.framework.AssertionFailedError: Error in test '6.0-alpha2 -> [7.0]' 
> while upgrading to '7.0'; successful upgrades [5.0.9 -> [7.0]]
>       at 
> org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:414)
>       at 
> org.apache.cassandra.distributed.upgrade.ClusterMetadataUpgradeAssassinateTest.simpleUpgradeTest(ClusterMetadataUpgradeAssassinateTest.java:52)
>       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Caused by: java.lang.AssertionError: nodetool command [cms, initialize] was 
> not successful
> stdout:
> nodetool: Can't upgrade from gossip since CMS is already initialized
> See 'nodetool help' or 'nodetool help <command>'.
> stderr:
> Notifications:
> Error:
> java.lang.IllegalStateException: Can't upgrade from gossip since CMS is 
> already initialized
>       at 
> org.apache.cassandra.tcm.ClusterMetadataService.upgradeFromGossip(ClusterMetadataService.java:438)
>       at 
> org.apache.cassandra.tcm.CMSOperations.initializeCMS(CMSOperations.java:86)
>       at 
> org.apache.cassandra.tools.nodetool.CMSAdmin$InitializeCMS.execute(CMSAdmin.java:100)
>       at 
> org.apache.cassandra.tools.nodetool.AbstractCommand.run(AbstractCommand.java:64)
>       at picocli.CommandLine.executeUserObject(CommandLine.java:2045)
>       at picocli.CommandLine.access$1500(CommandLine.java:148)
>       at 
> picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2469)
>       at picocli.CommandLine$RunLast.handle(CommandLine.java:2461)
>       at picocli.CommandLine$RunLast.handle(CommandLine.java:2423)
>       at 
> picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2277)
>       at picocli.CommandLine$RunLast.execute(CommandLine.java:2425)
>       at 
> org.apache.cassandra.tools.nodetool.JmxConnect$JmxConnectionCommandInvoker.execute(JmxConnect.java:206)
>       at 
> org.apache.cassandra.tools.nodetool.JmxConnect.executionStrategy(JmxConnect.java:97)
>       at picocli.CommandLine.execute(CommandLine.java:2174)
>       at org.apache.cassandra.tools.NodeTool.execute(NodeTool.java:133)
>       at 
> org.apache.cassandra.distributed.impl.Instance$DTestNodeTool.execute(Instance.java:1244)
>       at 
> org.apache.cassandra.distributed.impl.Instance.lambda$nodetoolResult$57(Instance.java:1153)
>       at org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61)
>       at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71)
>       at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>       at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>       at 
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
>       at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
> we are upgrading from 6.0 to trunk and it seems we re-initialize on trunk 
> while it is already all initialized from times 6.0 started. 
> Possible solutions:
> 1) do not throw, just warn
> 2) rework tests so we do not initialize again when starting post-6.0 versions
> This pattern is repeating and by fixing this we resolve whole class of 
> failures.
> (1) https://pre-ci.cassandra.apache.org/job/cassandra/521/#showFailuresLink



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to