Copilot commented on code in PR #465:
URL:
https://github.com/apache/cassandra-nodejs-driver/pull/465#discussion_r3384505580
##########
.github/workflows/test.yml:
##########
@@ -46,6 +46,29 @@ jobs:
node -e "require('./api-generation-test').generate()" > generated.ts
npx tsc --noEmit
+ bun-unit-tests:
+ name: Unit tests on Bun
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ - uses: oven-sh/setup-bun@v2
+ with:
+ bun-version: latest
Review Comment:
Using `bun-version: latest` can introduce CI breakages when Bun makes
breaking changes. Consider pinning to a major (or specific) version to keep the
workflow stable.
##########
.github/workflows/test.yml:
##########
@@ -46,6 +46,29 @@ jobs:
node -e "require('./api-generation-test').generate()" > generated.ts
npx tsc --noEmit
+ bun-unit-tests:
+ name: Unit tests on Bun
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ - uses: oven-sh/setup-bun@v2
+ with:
+ bun-version: latest
+ - run: bun install
+ - run: bunx mocha test/unit --recursive -R spec -t 5000
Review Comment:
`bun install` will resolve semver ranges without a committed `bun.lockb`, so
Bun CI may test a different dependency graph than `npm ci` (from
`package-lock.json`). For reproducible CI, consider committing `bun.lockb` and
switching to `bun install --frozen-lockfile`.
##########
.github/workflows/test.yml:
##########
@@ -46,6 +46,29 @@ jobs:
node -e "require('./api-generation-test').generate()" > generated.ts
npx tsc --noEmit
+ bun-unit-tests:
+ name: Unit tests on Bun
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ - uses: oven-sh/setup-bun@v2
+ with:
+ bun-version: latest
+ - run: bun install
+ - run: bunx mocha test/unit --recursive -R spec -t 5000
+
+ deno-unit-tests:
+ name: Unit tests on Deno
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ - uses: denoland/setup-deno@v2
+ with:
+ deno-version: latest
+ # --allow-scripts runs lifecycle scripts so the kerberos prebuild is
fetched.
+ - run: deno install --allow-scripts
+ - run: deno run -A --unstable-detect-cjs npm:mocha test/unit --recursive
-R spec -t 5000
Review Comment:
`deno install --allow-scripts` enables lifecycle scripts for all npm
packages. If only `kerberos` needs this (per the comment), consider scoping
`--allow-scripts` to just that package to reduce the blast radius.
##########
.github/workflows/test.yml:
##########
@@ -46,6 +46,29 @@ jobs:
node -e "require('./api-generation-test').generate()" > generated.ts
npx tsc --noEmit
+ bun-unit-tests:
+ name: Unit tests on Bun
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ - uses: oven-sh/setup-bun@v2
+ with:
+ bun-version: latest
+ - run: bun install
+ - run: bunx mocha test/unit --recursive -R spec -t 5000
+
+ deno-unit-tests:
+ name: Unit tests on Deno
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ - uses: denoland/setup-deno@v2
+ with:
+ deno-version: latest
Review Comment:
Using `deno-version: latest` can cause unexpected CI failures on new major
releases. Pinning to the current major avoids surprise upgrades.
##########
.github/workflows/test.yml:
##########
@@ -46,6 +46,29 @@ jobs:
node -e "require('./api-generation-test').generate()" > generated.ts
npx tsc --noEmit
+ bun-unit-tests:
+ name: Unit tests on Bun
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ - uses: oven-sh/setup-bun@v2
+ with:
+ bun-version: latest
+ - run: bun install
+ - run: bunx mocha test/unit --recursive -R spec -t 5000
+
+ deno-unit-tests:
+ name: Unit tests on Deno
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ - uses: denoland/setup-deno@v2
+ with:
+ deno-version: latest
+ # --allow-scripts runs lifecycle scripts so the kerberos prebuild is
fetched.
+ - run: deno install --allow-scripts
+ - run: deno run -A --unstable-detect-cjs npm:mocha test/unit --recursive
-R spec -t 5000
Review Comment:
`npm:mocha` without a version will pull whatever version is current at run
time, which can make CI flaky and diverge from the repo’s devDependency (`mocha
~10.8.2` in package.json). Pin the mocha version here to match the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
