skoppu22 commented on code in PR #144:
URL: 
https://github.com/apache/cassandra-analytics/pull/144#discussion_r3414009265


##########
cassandra-analytics-integration-framework/src/main/java/org/apache/cassandra/sidecar/testing/SharedClusterIntegrationTestBase.java:
##########
@@ -519,6 +530,22 @@ protected ResultSet queryAllDataWithDriver(QualifiedName 
table, ConsistencyLevel
         return session.execute(statement);
     }
 
+    /**
+     * Convenience method to count rows from the provided {@code table} at the 
specified consistency level.
+     *
+     * @param table       the qualified Cassandra table name
+     * @param consistency the consistency level to use for querying the data
+     * @return record count limited to 10000 rows
+     */
+    protected Long countDataWithDriver(QualifiedName table, ConsistencyLevel 
consistency)
+    {
+        Cluster driverCluster = createDriverCluster(cluster.delegate());

Review Comment:
   try-with-resources needed here I guess



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to