This is an automated email from the ASF dual-hosted git repository.
smiklosovic pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-sidecar.git
The following commit(s) were added to refs/heads/trunk by this push:
new 6a6b43eb CASSSIDECAR-476: Add spotbugsIntegrationTest to CircleCI and
GitHub CI
6a6b43eb is described below
commit 6a6b43eb0082c20ae62f6e4891a32bf7b3988570
Author: Paulo Motta <[email protected]>
AuthorDate: Tue Jun 16 11:47:35 2026 -0400
CASSSIDECAR-476: Add spotbugsIntegrationTest to CircleCI and GitHub CI
The spotbugsIntegrationTest task was not run in either CI system,
allowing SpotBugs violations in integration test sources to go
undetected.
patch by Paulo Motta; reviewed by Francisco Guerrero for CASSSIDECAR-476
---
.circleci/config.yml | 2 +-
.github/workflows/ci.yml | 2 +-
.../sidecar/db/ClusterOpsDatabaseAccessorIntegrationTest.java | 3 +++
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/.circleci/config.yml b/.circleci/config.yml
index e369d0db..162fb21f 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -270,7 +270,7 @@ jobs:
- attach_workspace:
at: dtest-jars
- run: ./scripts/install-shaded-dtest-jar-local.sh
- - run: ./gradlew --no-daemon --max-workers=2 -PdtestVersion=5.1
-Dcassandra.sidecar.versions_to_test="5.1" checkstyleIntegrationTest
integrationTestLightWeight --stacktrace
+ - run: ./gradlew --no-daemon --max-workers=2 -PdtestVersion=5.1
-Dcassandra.sidecar.versions_to_test="5.1" checkstyleIntegrationTest
spotbugsIntegrationTest integrationTestLightWeight --stacktrace
- save_gradle_cache
- store_artifacts:
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index b8bf8fe4..035ea91d 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -265,7 +265,7 @@ jobs:
./gradlew --no-daemon \
-PdtestVersion=${{ matrix.dtestVersion }} \
-Dcassandra.sidecar.versions_to_test="${{ matrix.cassandra }}" \
- integrationTestLightWeight \
+ spotbugsIntegrationTest integrationTestLightWeight \
--stacktrace
env:
CASSANDRA_DEP_DIR: ${{ github.workspace }}/dtest-jars
diff --git
a/server/src/test/integration/org/apache/cassandra/sidecar/db/ClusterOpsDatabaseAccessorIntegrationTest.java
b/server/src/test/integration/org/apache/cassandra/sidecar/db/ClusterOpsDatabaseAccessorIntegrationTest.java
index b0518fb9..84720cc0 100644
---
a/server/src/test/integration/org/apache/cassandra/sidecar/db/ClusterOpsDatabaseAccessorIntegrationTest.java
+++
b/server/src/test/integration/org/apache/cassandra/sidecar/db/ClusterOpsDatabaseAccessorIntegrationTest.java
@@ -112,6 +112,9 @@ class ClusterOpsDatabaseAccessorIntegrationTest extends
IntegrationTestBase
Instant firstStartTime = updated.startTime();
accessor.updateJobStatus(clusterName, jobId1, OperationType.REPAIR,
OperationalJobStatus.RUNNING, null);
OperationalJobRecord afterSecondRunning =
accessor.findJob(clusterName, jobId1);
+ assertThat(afterSecondRunning)
+ .withFailMessage("findJob should return the job after second
RUNNING update")
+ .isNotNull();
assertThat(afterSecondRunning.startTime())
.withFailMessage("start_time should not change on subsequent
RUNNING updates")
.isEqualTo(firstStartTime);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
