skoppu22 commented on code in PR #169:
URL:
https://github.com/apache/cassandra-analytics/pull/169#discussion_r3476325267
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java:
##########
@@ -390,33 +383,6 @@ public TokenRangeMapping<RingInstance>
getTokenRangeMapping(boolean cached)
}
}
- @Override
- public String getLowestCassandraVersion()
- {
- String currentCassandraVersion = cassandraVersion;
- if (currentCassandraVersion != null)
- {
- return currentCassandraVersion;
- }
-
- synchronized (this)
- {
- if (cassandraVersion == null)
- {
- String versionFromFeature = getVersionFromFeature();
- if (versionFromFeature != null)
- {
- // Forcing writer to use a particular version
- cassandraVersion = versionFromFeature;
- }
Review Comment:
Restored getVersionFromFeature call from getLowestCassandraVersion. Note
that only legacy fallback uses it, bridge determination feature doesn't use
getVersionFromFeature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
