[ 
https://issues.apache.org/jira/browse/CASSANDRA-20876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18092408#comment-18092408
 ] 

Maxim Muzafarov commented on CASSANDRA-20876:
---------------------------------------------

I think the current idea of stopping the promotion of options for local 
commands makes sense, and the `lhf` tag on it suggests that it’s fairly easy to 
implement. In other words, the command can still accept `jmx connect options` 
without returning an error.

If we want to change and remove the command’s options themselves, that’s a much 
riskier change from a backward compatibility standpoint, so I think it’s better 
to create a separate ticket and address how Mixins are added to commands in 
that one.

The current solution looks good.

> Offline nodetool commands should not print network options in help
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-20876
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20876
>             Project: Apache Cassandra
>          Issue Type: Improvement
>          Components: Tool/nodetool
>            Reporter: Stefan Miklosovic
>            Assignee: Arvind Kandpal
>            Priority: Normal
>              Labels: lhf
>             Fix For: 6.x, 7.x
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> There is no reason to print "network related options" like port, password 
> etc. for offline nodetool commands like "history" and similar. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to