[
https://issues.apache.org/jira/browse/CASSANDRA-21483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18092949#comment-18092949
]
Stefan Miklosovic commented on CASSANDRA-21483:
-----------------------------------------------
This will make the tarball about 5MB smaller, basically on-par with 5.0.
I have not used the same approach as used with Amazon Corretto Crypto Provider
because that provider is best-effort dependency (if fail_on_missing is false in
crypto_providers). But for ZSTD, Cassandra depends on it hard because without
it on the class path one would not be able to create any table using
ZstdCompressor. It is not optional. So I just enumerated all dependencies with
different classifiers. I have included Darwin too for Apple machines so devs
have easy life.
These Zstd native jars are packaging same classes all over again so it does not
matter from the classpath perspective which one gets loaded, technically.
https://github.com/apache/cassandra/pull/4913
> Use architecture-specific JARs for zstd-jni to get rid of unsupported
> platforms
> -------------------------------------------------------------------------------
>
> Key: CASSANDRA-21483
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21483
> Project: Apache Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Stefan Miklosovic
> Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> zstd-jni we depend on is an architectonic uber-jar with all platforms
> supported. This does not make a lot of sense in the context of Cassandra as
> we support only arm / x86 / maybe Macs for development.
> If we depended only on platform-specific JARs, we could get rid of few
> megabytes when it comes to final release tarball, effectively going back to
> the size of 5.x tarball for 6.0+
> We did something similar with Amazon Corretto Crypto Provider.
> https://github.com/luben/zstd-jni#binary-releases
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
