skoppu22 commented on code in PR #169:
URL:
https://github.com/apache/cassandra-analytics/pull/169#discussion_r3539127961
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/bridge/CassandraVersion.java:
##########
@@ -78,13 +109,69 @@ public String jarBaseName()
return jarBaseName;
}
- private static final String sstableFormat;
+ /**
+ * Get the set of SSTable formats supported by this Cassandra version.
+ *
+ * @return Set of supported SSTable format strings
+ */
+ public Set<String> sstableFormats()
+ {
+ return sstableFormats;
+ }
+
+ /**
+ * Get the list of native SSTable version strings for this Cassandra
version.
+ *
+ * @return List of native SSTable version strings
+ */
+ public List<String> getNativeSStableVersions()
Review Comment:
Done
##########
cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/bulkwriter/MockBulkWriterContext.java:
##########
@@ -378,9 +379,17 @@ public void checkBulkWriterIsEnabledOrThrow()
}
@Override
- public String getLowestCassandraVersion()
+ public CassandraVersion getBridgeVersion()
{
- return cassandraVersion;
+ return
CassandraVersion.fromVersion(cassandraVersion).orElse(CassandraVersion.FIVEZERO);
+ }
+
+ public Set<String> getSSTableVersionsOnCluster()
+ {
+ // Return SSTable versions based on Cassandra version for testing
+ CassandraVersion version =
CassandraVersion.fromVersion(cassandraVersion)
+ .orElse(CassandraVersion.FIVEZERO);
+ return new HashSet<>(version.getNativeSStableVersions());
}
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
