skoppu22 commented on code in PR #169:
URL:
https://github.com/apache/cassandra-analytics/pull/169#discussion_r3545089334
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java:
##########
@@ -515,9 +557,28 @@ public String getLowestVersion(List<NodeSettings>
allNodeSettings)
return ns.releaseVersion();
}
+ /**
+ * Retrieves SSTable versions using the existing cassandraContext.
Review Comment:
Done
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java:
##########
@@ -114,9 +114,9 @@ public class BulkSparkConf implements Serializable
// which will throw a configuration exception for each setting with
that prefix it does not recognize
public static final String SETTING_PREFIX = "spark.cassandra_analytics.";
- // Cassandra version of target cluster. Configuration parameter is exposed
to be able to correctly initialize static
- // components, before cluster version is discovered via Sidecar.
- public static final String CASSANDRA_VERSION =
SETTING_PREFIX + "cassandra.version";
+ // Disable SSTable version-based bridge determination. When true, falls
back to legacy mode.
Review Comment:
Done
##########
cassandra-analytics-core-example/src/main/java/org/apache/cassandra/spark/example/DirectWriteAndReadJob.java:
##########
@@ -36,7 +36,6 @@ public static void main(String[] args)
{
System.setProperty("SKIP_STARTUP_VALIDATIONS", "true");
// Configuration for Cassandra 5.x (and optionally BTI sstable format):
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
