yifan-c commented on code in PR #227:
URL:
https://github.com/apache/cassandra-analytics/pull/227#discussion_r3670991149
##########
cassandra-four-zero-types/src/main/java/org/apache/cassandra/spark/reader/AbstractSchemaBuilder.java:
##########
@@ -479,7 +479,8 @@ public CqlTable build()
replicationFactor,
fields,
new HashSet<>(udts.values()),
- indexCount);
+ indexCount,
+ enableCdc);
Review Comment:
Not an action item for this patch – we should consider applying the builder
pattern to `CqlTable`. The constructor overloads are error prone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
