[ 
https://issues.apache.org/jira/browse/CASSANALYTICS-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18099918#comment-18099918
 ] 

Yifan Cai commented on CASSANALYTICS-186:
-----------------------------------------

+1

> AbstractSchemaBuilder.build() drops the cdc flag, silently disabling CDC on 
> all tables
> --------------------------------------------------------------------------------------
>
>                 Key: CASSANALYTICS-186
>                 URL: https://issues.apache.org/jira/browse/CASSANALYTICS-186
>             Project: Apache Cassandra Analytics
>          Issue Type: Bug
>          Components: CDC
>            Reporter: Jyothsna Konisa
>            Assignee: Jyothsna Konisa
>            Priority: Normal
>             Fix For: 0.5
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Recent vector type commit in cassandra-analytics refactored SchemaBuilder (in 
> cassandra-four-zero-types) into a shared AbstractSchemaBuilder base class so 
> cassandra-four-zero-types and cassandra-five-zero-types could share common 
> schema-building logic to support the new vector type. During the extraction, 
> AbstractSchemaBuilder.build() dropped the trailing enableCdc argument from 
> its new CqlTable(...) constructor cal and It just silently discards whatever 
> enableCdc value was.
>  // before (SchemaBuilder.build()):
>  return new CqlTable(keyspace, metadata.name, createStmt, replicationFactor,
>                      fields, new HashSet<>(udts.values()), indexCount, 
> enableCdc);
>  // after (AbstractSchemaBuilder.build()):
>  return new CqlTable(keyspace, metadata.name, createStmt, replicationFactor,
>                      fields, new HashSet<>(udts.values()), indexCount);



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to