rustyrazorblade commented on PR #101:
URL:
https://github.com/apache/cassandra-easy-stress/pull/101#issuecomment-5296651758
Thanks for the review — pushed fixes for all four points in 0ae27d0:
1. **Blocker (`testAllVersions`/`./gradlew tasks` failure)**: confirmed and
fixed. Moved the `mustRunAfter` wiring out of the `register("testAllVersions")
{ }` block to top level — Gradle forbids mutating the task container from
inside another task's configuration action. `./gradlew tasks` and `./gradlew
testAllVersions` both verified working again.
2. **jib GC-flag drift**: the container's `JAVA_TOOL_OPTIONS` now derives
from the same JDK-version check as `bin/cassandra-easy-stress`, instead of
hardcoding `-XX:+ZGenerational`. No behavior change today (base image pinned to
JDK 21), but keeps the two launch paths from silently diverging if the base
image is ever bumped to JDK 23+.
3. **Stale `agrona` comment**: fixed — the JDK 17 constraint it referenced
no longer applies now that the project targets JDK 21.
4. **JDK 25 compile safety**: added `-Xjdk-release=21` to the Kotlin compile
tasks. `jvmTarget` alone only stamps the output class file version — it doesn't
restrict the compiler to APIs that actually exist on JDK 21. Without this, code
compiled under JDK 25 could reference a JDK 22-25-only stdlib API, compile
cleanly, and only fail with `NoSuchMethodError` on a real JDK 21 at runtime. No
current behavior change; verified clean builds on both JDK 21.0.10 and JDK
25.0.3.
Re-verified locally on both JDK 21 and JDK 25: `test`, `ktlintCheck`,
`detekt`, `distTar`, `shadowJar`, `jibDockerBuild` all pass (only the 2
pre-existing local-Docker-only test failures, unrelated).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
