[
https://issues.apache.org/jira/browse/CASSANDRA-21552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18104923#comment-18104923
]
Paulo Motta commented on CASSANDRA-21552:
-----------------------------------------
[~smiklosovic] before a forced repair would be retried indefinitely if there
was an error, if we make this change then the forced repair will be aborted if
there's an error - do we want to change this behavior? feels like it's a
different issue from the one being addressed on this ticket but we can also
address it here as long as we document this is changing the behavior of forced
repair.
[this|https://github.com/tommystendahl/cassandra/compare/cassandra21552-5.0...smiklosovic:cassandra:CASSANDRA-21552-5.0]
looks good, but we're clearing force repair regardless of whether it's a
forced repair or not, we should probably clear only if it's a forced repair,
also there's no test simulating a failure and
[this|https://github.com/smiklosovic/cassandra/blob/abbc5716ea6fedf42e59625a02a9c0e01f8fa580/src/java/org/apache/cassandra/repair/autorepair/AutoRepair.java#L281]
comment looks unnecessarily large
> Force repair should ignore min_repair_interval
> ----------------------------------------------
>
> Key: CASSANDRA-21552
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21552
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Feature/Repair
> Reporter: Tommy Stendahl
> Assignee: Tommy Stendahl
> Priority: Normal
> Fix For: 5.0.x, 6.x, 7.x
>
> Attachments: ci_summary_driftx_CASSANDRA-21552-5.0_184.html,
> ci_summary_driftx_CASSANDRA-21552-6.0_113.html,
> ci_summary_driftx_CASSANDRA-21552-trunk_665.html,
> results_details_driftx_CASSANDRA-21552-5.0_184.tar.xz,
> results_details_driftx_CASSANDRA-21552-6.0_113.tar.xz,
> results_details_driftx_CASSANDRA-21552-trunk_665.tar.xz
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> If you set force repair for a node the repair is not triggered until
> min_repair_interval has expired, this could be several hours. This seams like
> a mistake, if you need to do a force repair you probably want it executed
> ASAP regardless of min_repair_interval.
> The problem is that in AutoRepair.java, tooSoonToRunRepair() is called before
> myTurnToRunRepair(). Since tooSoonToRunRepair() checks if min_repair_interval
> has elapsed and returns early if it hasn't, a node with force_repair set is
> still blocked from triggering immediate repair.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
