[ 
https://issues.apache.org/jira/browse/CASSANDRA-21577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18105255#comment-18105255
 ] 

Stefan Miklosovic edited comment on CASSANDRA-21577 at 8/17/26 11:07 AM:
-------------------------------------------------------------------------

4.0 
https://github.com/apache/cassandra/compare/cassandra-4.0...smiklosovic:cassandra:CASSANDRA-21577-4.0?expand=1
4.1 
https://github.com/apache/cassandra/compare/cassandra-4.1...smiklosovic:cassandra:CASSANDRA-21577-4.1?expand=1

the rest is likely same as the trunk's patch. For these I am not getting all 
greens in custom index test.


was (Author: smiklosovic):
4.0 
https://github.com/apache/cassandra/compare/cassandra-4.0...smiklosovic:cassandra:CASSANDRA-21577-4.0?expand=1
4.1 
https://github.com/apache/cassandra/compare/cassandra-4.1...smiklosovic:cassandra:CASSANDRA-21577-4.1?expand=1

the rest is likely same as the trunk's patch. For 4.0 I am not getting all 
greens in custom index test.

> Fixes for fully-expired SSTable index notification in compaction
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-21577
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-21577
>             Project: Apache Cassandra
>          Issue Type: Bug
>          Components: Feature/2i Index, Local/Compaction, Local/Compaction/TWCS
>            Reporter: Francisco Guerrero
>            Assignee: Francisco Guerrero
>            Priority: Normal
>             Fix For: 4.0.x, 4.1.x, 5.0.x, 6.x
>
>
> In CASSANDRA-20829, secondary index implementations started receiving 
> notifications about rows fully expired during compaction. However, this 
> change introduced three issues:
> - A read error or a throwing custom indexer aborted the whole compaction. 
> Expired SSTables were never obsoleted and every retry hit the same failure.
> - The static row was never passed to removeRow, so static-column indexes 
> missed expired-data notifications.
> - NoOpIndex, PaxosUncommittedIndex and RouteJournalIndex inherited the 
> default (true) and did no useful work on this path, forcing needless full 
> scans of expired SSTables on system.paxos / accord tables. Opt them out 
> matching SAI/SASI.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to