bianca-stanciu29 commented on code in PR #223:
URL:
https://github.com/apache/cassandra-analytics/pull/223#discussion_r3844667045
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java:
##########
@@ -276,6 +278,11 @@ public BulkSparkConf(SparkConf conf, Map<String, String>
options, @Nullable Logg
this.configuredJobId = MapUtils.getOrDefault(options,
WriterOptions.JOB_ID.name(), null);
this.coordinatedWriteConfJson = MapUtils.getOrDefault(options,
WriterOptions.COORDINATED_WRITE_CONFIG.name(), null);
this.coordinatedWriteConf =
buildCoordinatedWriteConf(dataTransportInfo.getTransport(), logger);
+ if (this.sidecarBehindLoadBalancer && this.coordinatedWriteConf ==
null && logger != null)
+ {
+ logger.warn("{} is set but {} is not configured; the flag is only
honored for coordinated writes and will be ignored on the single-cluster path.",
Review Comment:
Went with your recommendation to make it generic rather than defer it:
SIDECAR_BEHIND_LOAD_BALANCER is now honored on both the single-cluster and
coordinated write paths, so single-cluster behind a load balancer is supported
directly for time-skew validation. Removed this warning since the flag is no
longer ignored on the single-cluster path, no follow-up Jira needed for this
case.
For context: per-instance request routing behind a shared load-balancer
address is a separate concern, enabled on the Sidecar side by
[CASSSIDECAR-495](https://issues.apache.org/jira/browse/CASSSIDECAR-495)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
