[
https://issues.apache.org/jira/browse/CASSANDRA-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168924#comment-13168924
]
Sylvain Lebresne commented on CASSANDRA-3483:
---------------------------------------------
I haven't applied the patch yet, it needs rebase and preferably against trunk
since that is the likely target for this, but a few comments.
We could have more reuse of code between Boostrapper ant the rebuild command.
Typically:
* RangeStreamer.getAllRangeWithSourcesFor does essentially the same thing that
Boostrapper.getRangesWithSources, so it would be nice to do some reuse.
* In rebuild, we essentially have the code of Boostrapper.getWorkMap, again
would be nice to do some code reuse.
I think we should move all of those in RangeStreamer and ultimately
Boostrapper.boostrap() should be just one call to rebuild with the right
arguments (mostly the correct tokenMetada instance and the "myRange"
collection).
A few nits:
* rebuild code could be simplified slightly by using
StorageService.getLocalRanges()
* rebuild doesn't fully respect the code style.
> Support bringing up a new datacenter to existing cluster without repair
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-3483
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3483
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.0.2
> Reporter: Chris Goffinet
> Assignee: Peter Schuller
> Attachments: CASSANDRA-3483-0.8-prelim.txt, CASSANDRA-3483-1.0.txt
>
>
> Was talking to Brandon in irc, and we ran into a case where we want to bring
> up a new DC to an existing cluster. He suggested from jbellis the way to do
> it currently was set strategy options of dc2:0, then add the nodes. After the
> nodes are up, change the RF of dc2, and run repair.
> I'd like to avoid a repair as it runs AES and is a bit more intense than how
> bootstrap works currently by just streaming ranges from the SSTables. Would
> it be possible to improve this functionality (adding a new DC to existing
> cluster) than the proposed method? We'd be happy to do a patch if we got some
> input on the best way to go about it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira