[
https://issues.apache.org/jira/browse/CASSANDRA-21517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18111432#comment-18111432
]
Michael Semb Wever commented on CASSANDRA-21517:
------------------------------------------------
[~jeremiah] , addressed in (the squash commit)
https://github.com/apache/cassandra/commit/9701daf62d51bd055671f2edc54399e5fbfcea52
> Guardrail values of zero to mean literally zero
> -----------------------------------------------
>
> Key: CASSANDRA-21517
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21517
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Feature/Guardrails
> Reporter: Michael Semb Wever
> Assignee: Michael Semb Wever
> Priority: Normal
> Fix For: 6.0.x, 7.x
>
> Attachments: ci_summary.html, results_details.tar.xz
>
>
> Guardrail values of -1 and 0 both mean unlimited.
> https://github.com/apache/cassandra/blob/cassandra-6.0/src/java/org/apache/cassandra/db/guardrails/MaxThreshold.java#L60
> This comes from CASSANDRA-17146 and appears to have been an oversight.
> This creates difficulties when you need finer control of the guardrails, like
> not being able to configure "more than 0 is a warning" or "more than 0 is a
> failure".
> For example, a typically recommended approach to secondary indexes would be as
> {code}
> # disable secondary_indexes
> secondary_indexes_total_fail_threshold = 0
> # disable sasi
> sasi_indexes_total_fail_threshold: 0
> # unlimited sai, but max ten per table
> sai_indexes_per_table_fail_threshold: 10
> sai_indexes_total_fail_threshold: -1
> {code}
> Discussion on the ticket happened here:
> https://the-asf.slack.com/archives/CK23JSY2K/p1783960683402379
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
