[
https://issues.apache.org/jira/browse/CASSANDRA-21496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
George updated CASSANDRA-21496:
-------------------------------
Test and Documentation Plan:
Validated commit 335aeb53411c7e5190d13079bd70cff5597b4b7f on OpenJDK 17.0.19
and Ant 1.10.13.
Regression tests exercise the DataMovement handler and completion payload, the
materialized-view write-path decision, actual data restoration during
removenode, and remote CMS log streaming. The handler test and both distributed
tests fail before the fix (expected RESTORE_REPLICA_COUNT, actual OTHER) and
pass with the fix.
Commands run successfully:
{code:bash}
.build/build-jars.sh -s
.build/run-tests.sh -s -a test -t
'/DataMovementVerbHandlerTest.java,/CassandraStreamReceiverTest.java,/StreamOperationTest.java'
.build/run-tests.sh -s -a jvm-dtest -t
'/RemoveNodeStreamingTest.java,/ReconfigureCMSStreamingTest.java'
.build/check-code.sh -s
git diff --check
{code}
Results: 9 unit tests and 2 JVM distributed tests passed, with no skips. RAT
and production/test Checkstyle passed.
Documentation: CHANGES.txt records the fix. No new configuration, API, or wire
format is introduced.
Full suites, mixed-version tests, and backport tests have not been run.
Community pre-commit CI is pending; reviewer/committer assistance is requested
in the linked comment.
PR: https://github.com/apache/cassandra/pull/5218
Status: Patch Available (was: Open)
> RemoveNodeStreams and ReconfigureCMS RESTORE_REPLICA_COUNT streams received
> by replicas are mis-parsed as OTHER.
> ----------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-21496
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21496
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming
> Reporter: Aleksey Yeschenko
> Assignee: George
> Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{RemoveNodeStreams#startStreaming()}} and {{ReconfigureCMS#streamRanges()}}
> build an {{INITIATE_DATA_MOVEMENTS_REQ}} payload
> whose {{streamOperation}} field is set to
> {{StreamOperation.RESTORE_REPLICA_COUNT.name()}}, i.e. the enum constant name
> {{RESTORE_REPLICA_COUNT}}.
> {{DataMovementVerbHandler#doVerb()}} on the receiver parses that string with
> {{StreamOperation.fromString(message.payload.streamOperation))}},
> incorrectly getting {{StreamOperation.OTHER}} (since
> {{"RESTORE_REPLICA_COUNT" != "Restore replica count"}}).
> Current impact: this causes MVs to require rebuild unnecessarily on
> removenode.
> Future impact: this affects CEP-45 topology change logic. I have a temporary
> workaround there but it's inelegant.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
