bianca-stanciu29 commented on code in PR #226:
URL:
https://github.com/apache/cassandra-analytics/pull/226#discussion_r4165504816
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/data/QualifiedTableName.java:
##########
@@ -65,6 +65,14 @@ public String keyspace()
return keyspace;
}
+ /**
+ * @return the keyspace name, quoted with double quotes when {@code
quoteIdentifiers} is set
+ */
+ public String maybeQuotedKeyspace()
Review Comment:
@bbotella @yifan-c @frankgh I think keeping keyspace() and table() as
raw-name accessors. They’re also used for SSTable metadata, local data-layer
setup, and job statistics, so returning quoted names would require checking
those callers too. The separate maybeQuoted accessors let us apply quoting when
building Sidecar requests without changing other uses.
[CASSSIDECAR-475](https://issues.apache.org/jira/browse/CASSSIDECAR-475) fixes
the metadata lookup inside Sidecar, but that’s separate from what these
analytics accessors return. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
