yifan-c commented on code in PR #253:
URL:
https://github.com/apache/cassandra-analytics/pull/253#discussion_r4276016578
##########
cassandra-analytics-cdc-codec/src/test/java/org/apache/cassandra/cdc/avro/CqlToAvroSchemaConverterTest.java:
##########
@@ -182,6 +184,72 @@ public void testUdtType()
assertThat(readCqlType(schema, "c2")).as("CQL type for 'c2'
field").isEqualTo("frozen<list<frozen<udt_2>>>");
}
+ @Test
+ public void testRecordNamesAreValidAndUnique()
+ {
+ final String address = "CREATE TYPE address (city text);";
+ final String phone = "CREATE TYPE phone (number int);";
+ final String person = "CREATE TYPE person (home frozen<address>,
mobile frozen<phone>);";
Review Comment:
nit: remove `final`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
