Comment by [email protected]:
Score: Negative
General Comment:
fireOnce, to me, is a code smell indicating that your logic for timing out
the individual operations is incorrect.
It would have been simpler and more direct to just wrap each of the
existing methods in their own setTimeouts.
Line-by-line comments:
File: /lib/util.js (r266b18e0f6dcb6e1fd5bd6f24cc6b678f93a4a65)
===============================================================================
Line 7: exports.fireOnce = function fireOnce(fn) {
-------------------------------------------------------------------------------
I think requiring this kind of function is a sign we're doing things wrong.
For more information:
http://code.google.com/a/apache-extras.org/p/cassandra-node/source/detail?r=266b18e0f6dcb6e1fd5bd6f24cc6b678f93a4a65
