[ 
https://issues.apache.org/jira/browse/CASSANDRA-21702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18129714#comment-18129714
 ] 

Dmitry Konstantinov commented on CASSANDRA-21702:
-------------------------------------------------

The errors which I saw in CI were not related to the change (it seems the link 
is expired now).
So, just to double check I've re-run locally stress related tests - no 
regressions:
{code:java}
┌──────────────────────────────────────────┬───────────────────────────────────────────────────────┬───────┬────────────┐
│                  Group                   │                         Class      
                   │ Tests │   Result   │
├──────────────────────────────────────────┼───────────────────────────────────────────────────────┼───────┼────────────┤
│ ant stress-test (tools/stress/test/unit) │ DistributionGaussianTest           
                   │ 2     │ pass       │
├──────────────────────────────────────────┼───────────────────────────────────────────────────────┼───────┼────────────┤
│                                          │ DistributionSequenceTest           
                   │ 4     │ pass       │
├──────────────────────────────────────────┼───────────────────────────────────────────────────────┼───────┼────────────┤
│                                          │ OptionReplicationTest              
                   │ 1     │ pass       │
├──────────────────────────────────────────┼───────────────────────────────────────────────────────┼───────┼────────────┤
│                                          │ SettingsCredentialsTest            
                   │ 2     │ pass       │
├──────────────────────────────────────────┼───────────────────────────────────────────────────────┼───────┼────────────┤
│                                          │ SettingsMiscTest                   
                   │ 4     │ pass       │
├──────────────────────────────────────────┼───────────────────────────────────────────────────────┼───────┼────────────┤
│                                          │ SettingsNodeTest                   
                   │ 2     │ pass       │
├──────────────────────────────────────────┼───────────────────────────────────────────────────────┼───────┼────────────┤
│                                          │ StressSettingsTest                 
                   │ 2     │ pass       │
├──────────────────────────────────────────┼───────────────────────────────────────────────────────┼───────┼────────────┤
│                                          │ MultiResultLoggerTest              
                   │ 5     │ pass       │
├──────────────────────────────────────────┼───────────────────────────────────────────────────────┼───────┼────────────┤
│ test/unit tools tests                    │ CassandrastressTest (runs stress 
against a real node) │ 2     │ pass (76s) │
├──────────────────────────────────────────┼───────────────────────────────────────────────────────┼───────┼────────────┤
│                                          │ CompactionStressTest               
                   │ 2     │ pass (16s) │
└──────────────────────────────────────────┴───────────────────────────────────────────────────────┴───────┴────────────┘
{code}
 

So, I am proceeding with commit.

> Reduce prepared statement binding overhead for Cassandra stress 
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-21702
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-21702
>             Project: Apache Cassandra
>          Issue Type: Improvement
>          Components: Tool/stress
>            Reporter: Dmitry Konstantinov
>            Assignee: Dmitry Konstantinov
>            Priority: Normal
>             Fix For: 6.0.x, 7.x
>
>         Attachments: bind_lookup_overhead.png, stress_bind_after_cpu.html, 
> stress_bind_before_cpu.html
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Under high 10-row, 5 value column batch write load Cassandra stress burn a 
> lot of CPU to lookup Codecs for bound values: 21.5% of overall CPU 
> consumption ("codecFor" to seach in profiles).
> To avoid this overhead we can retrieve required codecs for a prepared 
> statement once and then use them explicitly when we bind values to avoid 
> codec lookup cost. It drops the codecFor lookup overhead to 0.
>  [^stress_bind_before_cpu.html] 
>  [^stress_bind_after_cpu.html] 
>  !bind_lookup_overhead.png|width=400! 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to