[
https://issues.apache.org/jira/browse/CASSANDRA-20927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18132439#comment-18132439
]
Branimir Lambov commented on CASSANDRA-20927:
---------------------------------------------
Patch LGTM.
> Fix ShardManager#coveringRange to include the first partition position
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-20927
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20927
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Local/Compaction
> Reporter: Michael Semb Wever
> Priority: Normal
> Fix For: 5.0.x, 6.0.x, 7.x
>
>
> Range is left exclusive. When constructing Range, it should decrement left
> position instead of incrementing right position.
> Also ShardManager#rangeSpanned for (min, min] should be 1 instead of 1 token
> span.
> Impact is trivial: it can cause is a range to be measured to span 0 range
> instead of 2^-64 (if it only contains one partition that falls on a local
> ownership boundary), but this is then anyway corrected to give it a sensible
> density.
> The min-min case only relates to tests.
> downstream patch:
> https://github.com/datastax/cassandra/commit/dd5da490b5705a61b49bc6bfadf6a47a973c9804
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]