2 new revisions:
Revision: a5cb8316d8e8
Author: Tomaz Muraus <[email protected]>
Date: Sun Dec 25 16:24:07 2011
Log: Also report scope leaks in tests.
http://code.google.com/a/apache-extras.org/p/cassandra-node/source/detail?r=a5cb8316d8e8
Revision: de8416998265
Author: Tomaz Muraus <[email protected]>
Date: Sun Dec 25 16:31:45 2011
Log: Fix some scope leaks - add missing var.
http://code.google.com/a/apache-extras.org/p/cassandra-node/source/detail?r=de8416998265
==============================================================================
Revision: a5cb8316d8e8
Author: Tomaz Muraus <[email protected]>
Date: Sun Dec 25 16:24:07 2011
Log: Also report scope leaks in tests.
http://code.google.com/a/apache-extras.org/p/cassandra-node/source/detail?r=a5cb8316d8e8
Modified:
/package.json
=======================================
--- /package.json Sun Dec 25 16:11:11 2011
+++ /package.json Sun Dec 25 16:24:07 2011
@@ -19,7 +19,7 @@
"lib": "lib"
},
"scripts": {
- "test": "whiskey --tests \"test/test_driver.js test/test_decoder.js
test/test_uuid.js\" --dependencies test/dependencies.json"
+ "test": "whiskey --tests \"test/test_driver.js test/test_decoder.js
test/test_uuid.js\" --dependencies test/dependencies.json --scope-leaks"
},
"engines": {
"node": ">= 0.4.0"
==============================================================================
Revision: de8416998265
Author: Tomaz Muraus <[email protected]>
Date: Sun Dec 25 16:31:45 2011
Log: Fix some scope leaks - add missing var.
http://code.google.com/a/apache-extras.org/p/cassandra-node/source/detail?r=de8416998265
Modified:
/lib/driver.js
/lib/system.js
=======================================
--- /lib/driver.js Mon Dec 19 14:50:34 2011
+++ /lib/driver.js Sun Dec 25 16:31:45 2011
@@ -214,9 +214,9 @@
// Construct a list of nodes from hosts in <host>:<port> form
for (var i = 0; i < config.hosts.length; i++) {
- hostSpec = config.hosts[i];
+ var hostSpec = config.hosts[i];
if (!hostSpec) { continue; }
- host = hostSpec.split(':');
+ var host = hostSpec.split(':');
if (host.length > 2) {
log.warn('malformed host entry "' + hostSpec + '" (skipping)');
}
=======================================
--- /lib/system.js Thu Apr 21 13:02:25 2011
+++ /lib/system.js Sun Dec 25 16:31:45 2011
@@ -29,7 +29,7 @@
var ColumnDef = module.exports.ColumnDef = ttypes.ColumnDef;
/** encapsulates a connection (thrift proto) and a client bound to it. */
-ThriftConnection = function(thriftCon, thriftCli) {
+var ThriftConnection = function(thriftCon, thriftCli) {
this.thriftCon = thriftCon;
this.thriftCli = thriftCli;
};
@@ -39,7 +39,7 @@
};
/** A pool of thrift connections. keeping this class around because
driver.js will eventually use something like this */
-Pool = function(urns) {
+var Pool = function(urns) {
this.connecting = [];
this.connections = [];
this.connectors = [];
@@ -165,7 +165,7 @@
}
/** system database */
-System = module.exports.System = function(urn) {
+var System = module.exports.System = function(urn) {
EventEmitter.call(this);
this.q = new Queue(500);
this.pool = new Pool([urn]);
@@ -215,7 +215,7 @@
/** shuts down thrift connection */
System.prototype.close = function(callback) {
- self = this;
+ var self = this;
this.q.put(function() {
self.pool.tearDown();
if (callback) {
