[ 
https://issues.apache.org/jira/browse/CASSANDRA-3667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178460#comment-13178460
 ] 

Sylvain Lebresne commented on CASSANDRA-3667:
---------------------------------------------

Looks good. Two nits:
* We probably should default to KEYS_ONLY rather than ALL to mimic our current 
default (and besides, having row cache opt-in seems like a saner default since 
for some CF it can do more harm than good).
* CliClient.showKeyspace() uses "cache:". Let's use "caching:" for consistency 
sake.

bq. you can reuse old cache settings for that purpose

Using the old settings on the long run would be weird and confusing, but I do 
am slightly worried about the pain on upgrade that the new global caches will 
incur to users, and it could be nice on upgrade to automatically set the value 
of this option for existing column families based on the preceding setting 
(basically use the information of whether this CF used to be cached or not). 
This may not be completely trivial though.
                
> We need a way to deactivate row/key caching on a per-cf basis.
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-3667
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3667
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Pavel Yaskevich
>            Assignee: Pavel Yaskevich
>             Fix For: 1.1
>
>         Attachments: CASSANDRA-3667.patch
>
>
> Initial idea would be to either have a boolean flag if we only want to allow 
> disabling row cache, or some multi-value caches option that could be "none", 
> "key_only", "row_only" or "all".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to