[ 
https://issues.apache.org/jira/browse/CASSANDRA-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178795#comment-13178795
 ] 

Jonathan Ellis commented on CASSANDRA-3688:
-------------------------------------------

To be fair, it's more "change for the sake of shutting up findbugs," which is 
good if it reduces the effort we have to do to investigate future reports.  
This is the "right" way to loop over maps in Java so I'd be +1 for trunk.
                
> [patch] avoid map lookups in loops by using entrysets
> -----------------------------------------------------
>
>                 Key: CASSANDRA-3688
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3688
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.6
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 1.0.7
>
>         Attachments: use_entrysets.diff
>
>
> code loops over the keySet and does gets for the value, just use entrySet()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to