[
https://issues.apache.org/jira/browse/CASSANDRA-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylvain Lebresne updated CASSANDRA-3559:
----------------------------------------
Attachment: 3559-v3.patch
Attaching v3 that replaces the avro tests by the test of the new native format.
The latter had two problem:
* It was throwing a NPE when deserializing a null ByteBuffer value; this is
currently a blocker for CASSANDRA-3761.
* It wasn't respecting null values for primitive types. Typically the
fromSchema(toSchema()) cycle was replacing a non-set bloomFilterChance by one
being set to 0.0.
v3 fixes both problem.
> CFMetaData conversions to Thrift/Native schema should be inverse one of the
> other
> ---------------------------------------------------------------------------------
>
> Key: CASSANDRA-3559
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3559
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Labels: avro, thrift
> Fix For: 1.1
>
> Attachments: 3559-v3.patch, 3559.patch, CASSANDRA-3559-v2.patch
>
>
> In other word, it would probably be a good idea to have:
> {noformat}
> cfm == CFMetadata.fromThrift(cfm.toThrift())
> cfm == CFMetadata.fromSchema(cfm.toSchema())
> {noformat}
> In particular, we could have unit tests to check that, which would avoid
> things like CASSANDRA-3558.
> It is not the case today for thrift because of the keyAlias. For some reason,
> if the keyAlias is not set, we return with toThrift() the default alias. I
> don't think this serves any purpose though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
